Skip to content

ci: unblock PR builds broken by Codecov v4 uploader sunset - #1006

Merged
ianmcorvidae merged 1 commit into
masterfrom
codecov-fix
Nov 18, 2026
Merged

ianmcorvidae merged 1 commit into
masterfrom
codecov-fix

Conversation

@ianmcorvidae

@ianmcorvidae ianmcorvidae commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Every PR build job since ~Sept has failed at 'Upload coverage to Codecov': the codecov-action v4 uploader was sunset by Codecov, and with fail_ci_if_error: true plus the default fail-fast matrix, one codecov failure marks the whole build red and cancels the remaining Python versions. Tests themselves pass (validate + lint + mypy + the full pytest suite all green on these PRs).

  • bump codecov/codecov-action v4 -> v5 (the documented migration; v5 uses the current uploader and the workflow already passes ${{ secrets.CODECOV_TOKEN }})
  • set fail_ci_if_error: false so coverage upload is best-effort until the CODECOV_TOKEN secret is confirmed current -- a coverage-hosting outage must never gate merges again

After this lands: rebase the open dependabot PRs (@dependabot rebase or they auto-rebase on master change) so they pick up the fixed workflow and go green.

Summary by CodeRabbit

  • Chores
    • Updated automated test-coverage reporting. Coverage upload issues no longer cause the build to fail.

Every PR build job since ~Sept has failed at 'Upload coverage to
Codecov': the codecov-action v4 uploader was sunset by Codecov, and
with fail_ci_if_error: true plus the default fail-fast matrix, one
codecov failure marks the whole build red and cancels the remaining
Python versions. Tests themselves pass (validate + lint + mypy + the
full pytest suite all green on these PRs).

- bump codecov/codecov-action v4 -> v5 (the documented migration;
  v5 uses the current uploader and the workflow already passes
  ${{ secrets.CODECOV_TOKEN }})
- set fail_ci_if_error: false so coverage upload is best-effort until
  the CODECOV_TOKEN secret is confirmed current -- a coverage-hosting
  outage must never gate merges again

After this lands: rebase the open dependabot PRs (@dependabot rebase
or they auto-rebase on master change) so they pick up the fixed
workflow and go green.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The CI workflow now uses Codecov Action v5 for coverage uploads and sets fail_ci_if_error to false. The other upload settings remain unchanged.

Changes: CI coverage upload

Layer / File(s) Summary
Update coverage upload settings
.github/workflows/ci.yml
The coverage upload uses Codecov Action v5 and sets fail_ci_if_error to false. Other upload settings remain unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: mkinney

Merge Risk: Low · up to 51b0d

The workflow now keeps coverage upload failures from blocking merges. However, with the new setting, the Codecov uploader will still run, along with the upload token, if its integrity check fails. Set fail_ci_if_error to true and mark the step continue-on-error so uploads stay non-blocking without running an unverified binary.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ianmcorvidae
ianmcorvidae merged commit 2da067b into master Nov 18, 2026
5 of 12 checks passed
@ianmcorvidae
ianmcorvidae deleted the codecov-fix branch November 18, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant